Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support internal load balancer setup on Azure #2608

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Support internal load balancer setup on Azure #2608

wants to merge 3 commits into from
+50 −5

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Nov 16, 2023 •
edited
Loading

Context

Proposed change(s)

Additional info

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@3u13r 3u13r added the feature This introduces new functionality label Nov 16, 2023
@3u13r 3u13r added this to the v2.14.0 milestone Nov 16, 2023
@3u13r 3u13r requested a review from derpsteb as a code owner November 16, 2023 14:10
@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 4c8f2b7
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/656488e0072f740008ef9bc9
😎 Deploy Preview https://deploy-preview-2608--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@3u13r 3u13r force-pushed the feat/cli/allow-internal-lb-on-azure branch from 0a858cc to 8798f58 Compare November 16, 2023 14:58
@3u13r
Copy link
Member Author

3u13r commented Nov 17, 2023

Ah the strict node-to-node routing in combination with Azure internal LB's not doing SNAT breaks this feature for now. I can fix this in our Cilium fork though. We'll need another exception port (as we already do for both etcd ports).
Converting to draft until then.

@3u13r 3u13r marked this pull request as draft November 17, 2023 09:18
@3u13r 3u13r force-pushed the feat/cli/allow-internal-lb-on-azure branch from 39860b4 to 1ff5ccc Compare November 23, 2023 21:10
@3u13r
cli: allow internal lb on azure
bc91563 
We don't use konnectivity anymore. Therefore, we can enable internal
using an internal load balancer on azure.
@3u13r
ci: add internal lb test to weekly and release
71f55a6
@3u13r
fixup! ci: add internal lb test to weekly and release
4c8f2b7
@3u13r 3u13r force-pushed the feat/cli/allow-internal-lb-on-azure branch from 1ff5ccc to 4c8f2b7 Compare November 27, 2023 12:17
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
internal/config 79.20% 79.20% ↔️

@3u13r 3u13r modified the milestones: v2.14.0, v2.15.0 Dec 11, 2023
@burgerdev burgerdev modified the milestones: v2.15.0, v2.16.0 Jan 26, 2024
@malt3 malt3 modified the milestones: v2.16.0, v2.17.0 Feb 29, 2024
@burgerdev burgerdev modified the milestones: v2.17.0, v2.18.0 Jun 26, 2024
@burgerdev burgerdev modified the milestones: v2.18.0, v2.19.0 Sep 9, 2024
@burgerdev burgerdev removed this from the v2.19.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derpsteb derpsteb derpsteb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@3u13r @derpsteb @malt3 @burgerdev